chore: add additional type-hints for gitlab/base.py#1345
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Feb 28, 2021
JohnVillalovos:jlvillal/mypy_base_fixes
Merged
chore: add additional type-hints for gitlab/base.py#1345nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/mypy_base_fixes
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/mypy_base_fixes
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 80.07% 80.10% +0.03%
==========================================
Files 72 72
Lines 3764 3770 +6
==========================================
+ Hits 3014 3020 +6
Misses 750 750
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Add type-hints for the variables which are set via self.__dict__ mypy doesn't see them when they are assigned via self.__dict__. So declare them in the class definition.
nejch
approved these changes
Feb 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type-hints for the variables which are set via self.dict
mypy doesn't see them when they are assigned via self.dict. So
declare them in the class definition.