chore: add type-hints for gitlab/mixins.py#1344
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Mar 6, 2021
JohnVillalovos:jlvillal/mixins
Merged
chore: add type-hints for gitlab/mixins.py#1344nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/mixins
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/mixins
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 80.08% 79.92% -0.17%
==========================================
Files 73 73
Lines 3812 4010 +198
==========================================
+ Hits 3053 3205 +152
- Misses 759 805 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohnVillalovos
changed the title
nejch
reviewed
Mar 6, 2021
* Added type-hints for gitlab/mixins.py
* Changed use of filter with a lambda expression to
list-comprehension. mypy was not able to understand the previous
code. Also list-comprehension is better :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list-comprehension. mypy was not able to understand the previous
code. Also list-comprehension is better :)