chore: add and fix some type-hints in gitlab/client.py #1343
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Feb 28, 2021
JohnVillalovos:jlvillal/mypy_testing_things
Merged
chore: add and fix some type-hints in gitlab/client.py #1343nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/mypy_testing_things
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/mypy_testing_things
Conversation
JohnVillalovos
changed the title
Was able to figure out better type-hints for gitlab/client.py
nejch
approved these changes
Feb 28, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Cool, looks like all method returns are now covered in client.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was able to figure out better type-hints for gitlab/client.py