chore: add type-hints to gitlab/client.py#1339
chore: add type-hints to gitlab/client.py#1339max-wittig merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/mypy_client_py
Conversation
Adding some initial type-hints to gitlab/client.py
|
@JohnVillalovos I love these type merge requests. Just a quick question. What about the depreciation of the typing module in Python 3.9? We may need some feature imports then right? |
I was not aware of that. But I just read this: https://docs.python.org/3/library/typing.html
Which sounds like we will have 5 years to take care of this. Maybe I misunderstand that. |
|
Okay then it should be fine. |
|
Thanks for the MR! |
Slowly coming along. One file at a time! |
Adding some initial type-hints to gitlab/client.py
Unsure about my usage of assert to identify the type of the object. Feedback appreciated.