fix: undefined name errors#1322
fix: undefined name errors#1322nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/missing_vars
Conversation
Discovered that there were some undefined names.
Codecov Report
@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 80.25% 80.25%
=======================================
Files 71 71
Lines 3738 3738
=======================================
Hits 3000 3000
Misses 738 738
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Wow thanks, really need more test coverage for this.
Some of this must have just worked before some of the refactoring because of those blanket imports. Or no one ever noticed 🤔
I ran flake8 locally after doing the patch to remove the 'import *' lines. And found these missing names. |
3 participants
Discovered that there were some undefined names.