chore: remove unused function _construct_url()#1321
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Feb 23, 2021
JohnVillalovos:jlvillal/remove_cruft
Merged
chore: remove unused function _construct_url()#1321nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/remove_cruft
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/remove_cruft
Conversation
The function _construct_url() was used by the v3 API. All usage of the function was removed in commit fe89b94
nejch
approved these changes
Feb 23, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Agreed, was wondering some time ago if this was ever still going to be useful :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function _construct_url() was used by the v3 API. All usage of the
function was removed in commit
fe89b94