chore: remove usage of 'from ... import *' in client.py#1318
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Feb 22, 2021
JohnVillalovos:jlvillal/testing
Merged
chore: remove usage of 'from ... import *' in client.py#1318nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/testing
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/testing
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
==========================================
- Coverage 80.76% 80.72% -0.04%
==========================================
Files 69 69
Lines 3623 3627 +4
==========================================
+ Hits 2926 2928 +2
- Misses 697 699 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In gitlab/client.py remove usage of: * from gitlab.const import * * from gitlab.exceptions import * Change them to: * import gitlab.const * import gitlab.exceptions Update code to explicitly reference things in gitlab.const and gitlab.exceptions A flake8 run no longer lists any undefined variables. Before it listed possible undefined variables.
JohnVillalovos
changed the title
nejch
approved these changes
Feb 22, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks! Would make sense to get rid of these blanket imports even in init but there are many things advertised publicly from that namespace even in docs (https://python-gitlab.readthedocs.io/en/stable/search.html?q=constants).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.