Enable mypy type checking and add type hints to gitlab/base.py#1299
Enable mypy type checking and add type hints to gitlab/base.py#1299nejch merged 2 commits intopython-gitlab:masterfrom JohnVillalovos:mypy
Conversation
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks again @JohnVillalovos. Maybe this could be added to CI as well then, e.g. with the lint jobs:
python-gitlab/.github/workflows/lint.yml
Line 14 in bec2094
Although the test workflows might give you an idea on how to add tox.
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
==========================================
+ Coverage 80.76% 80.78% +0.02%
==========================================
Files 69 69
Lines 3623 3628 +5
==========================================
+ Hits 2926 2931 +5
Misses 697 697
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohnVillalovos
changed the title
JohnVillalovos
changed the title
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Just a left a few more comments on the CI/tox setup, not sure if this is still WIP or if the file list is complete :)
|
I think I have done all the requested changes and I believe it is ready for review now. Thanks. |
Add an initial mypy test to test gitlab/base.py and gitlab/__init__.py
|
Rebased to fix merge conflicts |
|
Woo hoo, merged! 🙂 Thanks! |
3 participants
Add an initial mypy test to test gitlab/base.py and gitlab/init.py