fix(merge): parse arguments as query_data#1121
Merged
max-wittig merged 1 commit intopython-gitlab:masterfrom Jun 19, 2020
ferhat-aram:fix/bad-merge-request-arg-parsing
Merged
fix(merge): parse arguments as query_data#1121max-wittig merged 1 commit intopython-gitlab:masterfrom ferhat-aram:fix/bad-merge-request-arg-parsing
max-wittig merged 1 commit intopython-gitlab:masterfrom
ferhat-aram:fix/bad-merge-request-arg-parsing
Conversation
Member
|
Thanks for the MR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #1120
Merge request requests aren't working, as the request parameters
should_remove_source_branchandremove_source_branchare parsed aspost_data, when they should be send as query_string, as described in the official GitLab API documentation itself GitLab API Accept Merge