feat: add support for commit GPG signature#1055
Merged
max-wittig merged 2 commits intopython-gitlab:masterfrom Mar 22, 2020
nejch:feat/commit-gpg-signature
Merged
feat: add support for commit GPG signature#1055max-wittig merged 2 commits intopython-gitlab:masterfrom nejch:feat/commit-gpg-signature
max-wittig merged 2 commits intopython-gitlab:masterfrom
nejch:feat/commit-gpg-signature
Conversation
Member
|
Awesome quality, as always! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1050.
The functional tests currently only test that the server returns the correct 404 response for unsigned commits, since creating signed commits without the API would be a bit convoluted, maybe this can be added later? https://gitlab.com/gitlab-org/gitlab/-/issues/19185 might also help with this.
However, I've tested this against real signed and unsigned commits on gitlab.com: