chore: improve test environment for upcoming features#1054
Merged
max-wittig merged 4 commits intopython-gitlab:masterfrom Mar 22, 2020
nejch:chore/cleanup-test-env
Merged
chore: improve test environment for upcoming features#1054max-wittig merged 4 commits intopython-gitlab:masterfrom nejch:chore/cleanup-test-env
max-wittig merged 4 commits intopython-gitlab:masterfrom
nejch:chore/cleanup-test-env
Conversation
Member
|
That's really cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1052 and in some previous PRs, we've had to wait for a release to test new features on
latest.This PR allows contributors and CI (via either command-line flags or env variables) to define the image and tag to test against, and removes references to older python test environments.
Since
nightlymight be unstable I've added it toallow_failuresso it's not blocking but at least provides some feedback on new features. This can later be combined with@skipif(or similar) to run tests only against versions equal or higher than a specific GitLab version to improve development for upcoming features.