feat(api): add support for GitLab OAuth Applications using Applications API#1034
Merged
max-wittig merged 1 commit intopython-gitlab:masterfrom Mar 1, 2020
Merged
Conversation
Member
|
Thank you for the MR! I guess the commit message is a bit too long for commitlint. Would you mind to shorten it? You can put the rest of the information in the body of the commit message. |
filipowm
force-pushed
the
feat/api-oauth-applications
branch
5 times, most recently
from
7a86390 to
813f15b
Compare
filipowm
force-pushed
the
feat/api-oauth-applications
branch
from
813f15b to
4e12356
Compare
Contributor
Author
|
@max-wittig Finally, all passes :-) There were some gotchas that were difficult to find why tests are failing, but it works now! Would be nice to have some basic "developing guide", but it's truly nice to have.. |
Member
|
@filipowm I know, we kinda need some guidance, but first we need to have a nicer test setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitLab can be used as an OAuth authentication provider. GitLab API allows creating Applications which could benefit from this feature. Currently
python-gitlabdoes not support managing OAuth Apps, so I added this here.Reference: https://docs.gitlab.com/ce/api/applications.html