change path for set_approvers to new api, with defaulted rule_type an…#1005
Merged
max-wittig merged 4 commits intopython-gitlab:masterfrom Feb 12, 2020
Merged
Conversation
Member
|
@charlesfayal Thanks for the MR! Could you please also update the documentation and the tests? |
charlesfayal
force-pushed
the
fix_set_approvers
branch
5 times, most recently
from
a0481f9 to
fd5c24e
Compare
added 4 commits
January 30, 2020 21:21
Updated the gitlab path for set_approvers to approvers_rules, added default arg for rule type, and added arg for # of approvals required.
Updated the docs with the new set_approvers arguments, and updated tests with the arg as well.
Added a miss paramter update to the set_approvers function
to set the # of approvers for an MR you need to use the same function as for setting the approvers id.
charlesfayal
force-pushed
the
fix_set_approvers
branch
from
fd5c24e to
8e0c526
Compare
Contributor
Author
|
@max-wittig how's that? |
Contributor
Author
|
@max-wittig Im a little confused how to test this manually. How can I build the python projection into an importable project to test in my own project? |
Member
|
@charlesfayal You can just install the wheel with pip |
Member
|
@charlesfayal Just report back, when I should take a look |
Member
|
@charlesfayal Thanks for the MR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d added args for approvals_required