rework authentication API

Gauvain Pocentek · Gauvain Pocentek · commit eb4cd36fc329 · 2013-02-12T16:17:24.000+01:00
diff --git a/gitlab.py b/gitlab.py
@@ -43,30 +43,43 @@ def __init__(self, url, private_token=None, email=None, password=None):
         self.email = email
         self.password = password
 
-        if not self.private_token:
-            self.authenticate
+    def auth(self):
+        r = False
+        if self.private_token:
+            r = self.token_auth()
 
-    def authenticate(self, email=None, password=None):
-        self.email = self.email or email
-        self.password = self.password or password
+        if not r:
+            self.credentials_auth()
 
+    def credentials_auth(self):
         if not self.email or not self.password:
             raise GitlabAuthenticationError("Missing email/password")
 
-        r = self.rawPost('/session', {'email': email, 'password': password})
+        r = self.rawPost('/session', {'email': self.email, 'password': self.password})
         if r.status_code == 201:
             self.user = CurrentUser(self, r.json)
         else:
             raise GitlabAuthenticationError(r.json['message'])
 
         self.private_token = self.user.private_token
 
+    def token_auth(self):
+        try:
+            self.user = self.get(CurrentUser)
+            return True
+        except:
+            return False
+
     def setUrl(self, url):
         self.url = '%s/api/v3'%url
 
     def setToken(self, token):
         self.private_token = token
 
+    def setCredentials(self, email, password):
+        self.email = email
+        self.password = password
+
     def rawPost(self, path, data):
         url = '%s%s'%(self.url, path)
         try:
@@ -104,11 +117,14 @@ def list(self, objClass, **kwargs):
         else:
             raise GitlabGetError('%d: %s'%(r.status_code, r.text))
 
-    def get(self, objClass, id, **kwargs):
+    def get(self, objClass, id=None, **kwargs):
         url = objClass.url
         if kwargs:
             url = objClass.url % kwargs
-        url = '%s%s/%d?private_token=%s'%(self.url, url, id, self.private_token)
+        if id != None:
+            url = '%s%s/%d?private_token=%s'%(self.url, url, id, self.private_token)
+        else:
+            url = '%s%s?private_token=%s'%(self.url, url, self.private_token)
 
         try:
             r = requests.get(url)
@@ -273,10 +289,10 @@ def delete(self):
 
         return self.gitlab.delete(self)
 
-    def __init__(self, gl, data, **kwargs):
+    def __init__(self, gl, data=None, **kwargs):
         self.gitlab = gl
 
-        if isinstance(data, int):
+        if data is None or isinstance(data, int):
             data = self.gitlab.get(self.__class__, data, **kwargs)
 
         self.setFromDict(data)
@@ -442,14 +458,16 @@ def Tag(self, id=None):
         return self.getListOrObject(ProjectTag, id, project_id=self.id)
 
 if __name__ == '__main__':
-    # quick "doc"
+    # Quick "doc"
     #
     # See https://github.com/gitlabhq/gitlabhq/tree/master/doc/api for the
     # source
 
-    # register a connection to a gitlab instance, using its URL and a user
+    # Register a connection to a gitlab instance, using its URL and a user
     # private token
     gl = Gitlab('http://192.168.123.107:8080', 'JVNSESs8EwWRx5yDxM5q')
+    # Connect to get the current user (as gl.user)
+    gl.auth()
 
     # get a list of projects
     for p in gl.Project():
