refactor(asyncio): fix GitlabList

L0ric0 · L0ric0 · commit 5ffa3346305e · 2020-01-28T18:38:50.000+01:00
fix typo in v4/objects.py
add a async __setup__ to call after init is run
diff --git a/gitlab/__init__.py b/gitlab/__init__.py
@@ -650,14 +650,18 @@ async def http_list(self, path, query_data=None, as_list=None, **kwargs):
         url = self._build_url(path)
 
         if get_all is True and as_list is True:
-            return list(GitlabList(self, url, query_data, **kwargs))
+            return list(await GitlabList(self, url, query_data, **kwargs).__setup__())
 
         if "page" in kwargs or as_list is True:
             # pagination requested, we return a list
-            return list(GitlabList(self, url, query_data, get_next=False, **kwargs))
+            return list(
+                await GitlabList(
+                    self, url, query_data, get_next=False, **kwargs
+                ).__setup__()
+            )
 
         # No pagination, generator requested
-        return GitlabList(self, url, query_data, **kwargs)
+        return await GitlabList(self, url, query_data, **kwargs).__setup__()
 
     async def http_post(
         self, path, query_data=None, post_data=None, files=None, **kwargs
@@ -779,11 +783,16 @@ class GitlabList(object):
     the API again when needed.
     """
 
-    async def __init__(self, gl, url, query_data, get_next=True, **kwargs):
+    def __init__(self, gl, url, query_data, get_next=True, **kwargs):
         self._gl = gl
-        await self._query(url, query_data, **kwargs)
+        self.url = url
+        self.query_data = query_data
+        self.kwargs = kwargs
         self._get_next = get_next
 
+        async def __setup__(self):
+            await self._query(self.url, self.query_data, **self.kwargs)
+
     async def _query(self, url, query_data=None, **kwargs):
         query_data = query_data or {}
         result = await self._gl.http_request(
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
@@ -22,7 +22,7 @@
 
 from gitlab.base import *  # noqa
 from gitlab import cli
-from gitlab.exceptions import exc  # noqa
+from gitlab.exceptions import *  # noqa
 from gitlab.mixins import *  # noqa
 from gitlab import types
 from gitlab import utils
@@ -3701,7 +3701,7 @@ async def async_raw(
     def raw(
         self, file_path, ref, streamed=False, action=None, chunk_size=1024, **kwargs
     ):
-        loop = async.get_event_loop()
+        loop = asyncio.get_event_loop()
         return loop.run_until_complete(
             self.async_raw(
                 file_path, ref, streamed=False, action=None, chunck_size=1024, **kwargs
