Make todo() raise GitlabTodoError on error

Gauvain Pocentek · Gauvain Pocentek · commit 2167409fd638 · 2017-12-16T07:00:56.000+01:00
diff --git a/RELEASE_NOTES.rst b/RELEASE_NOTES.rst
@@ -16,6 +16,7 @@ Changes from 1.1 to 1.2
     ``set_token`` and ``set_credentials`` methods. Once a Gitlab object has been
     created its URL and authentication information cannot be updated: create a
     new Gitlab object if you need to use new information
+* The ``todo()`` method raises a ``GitlabTodoError`` exception on error
 
 Changes from 1.0.2 to 1.1
 =========================
diff --git a/gitlab/mixins.py b/gitlab/mixins.py
@@ -113,7 +113,12 @@ def get(self, id, **kwargs):
             GitlabAuthenticationError: If authentication is not correct
             GitlabGetError: If the server cannot perform the request
         """
-        gen = self.list()
+        try:
+            gen = self.list()
+        except exc.GitlabListError:
+            raise exc.GitlabGetError(response_code=404,
+                                     error_message="Not found")
+
         for obj in gen:
             if str(obj.get_id()) == str(id):
                 return obj
@@ -382,7 +387,7 @@ def unsubscribe(self, **kwargs):
 
 class TodoMixin(object):
     @cli.register_custom_action(('ProjectIssue', 'ProjectMergeRequest'))
-    @exc.on_http_error(exc.GitlabHttpError)
+    @exc.on_http_error(exc.GitlabTodoError)
     def todo(self, **kwargs):
         """Create a todo associated to the object.
 
