Improve oauthlib.oauth2.rfc6749#13965
Merged
srittau merged 5 commits intopython:mainfrom May 13, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
May 13, 2025
Comment on lines
+34
to
+35
| *args: Any, # actually, these are not used | ||
| **kwargs: Any, # actually, these are not used |
Collaborator
There was a problem hiding this comment.
If they are not used, we should use (_typeshed.)Unused instead of a comment. A potentially better option is to remove the arguments to prevent users from misspelling, e.g. Server(token_genarator=...) isn't an error with the current annotations.
Contributor
Author
There was a problem hiding this comment.
to be honest i already forgot why i preferred Any, but i think because subclasses can use them
and still I'll probably just remove them
stubs/oauthlib/oauthlib/oauth2/rfc6749/endpoints/pre_configured.pyi
Outdated
Show resolved
Hide resolved
stubs/oauthlib/oauthlib/oauth2/rfc6749/endpoints/pre_configured.pyi
Outdated
Show resolved
Hide resolved
stubs/oauthlib/oauthlib/oauth2/rfc6749/endpoints/pre_configured.pyi
Outdated
Show resolved
Hide resolved
stubs/oauthlib/oauthlib/oauth2/rfc6749/endpoints/pre_configured.pyi
Outdated
Show resolved
Hide resolved
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
May 13, 2025
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.