GH-98363: Presize the list for batched()#98419
Merged
rhettinger merged 6 commits intopython:mainfrom Oct 20, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presizing the result lists saves space from list over-allocation and is faster than the
PyList_Append()approach.This is a short PR but it took a while to figure out that
PyList_GetSlice()would make short work of the problem. Ideally, we need something like_PyTuple_Resize()to resize the list inplace using arealloc()and updating theallocatedfield.