gh-94713 - Replacing while 1 with while True#94714
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Nougat-Waffle
changed the title
|
Typically we don't accept changes like this, due to the churn involved. Is there any reason these need to be f-strings? |
These don't need to be f-strings. I just though that changing to f-strings would make the code better and so I did. Could u elaborate further on why changes like this aren't welcome ? |
There's always a chance for an error to be introduced in corner cases, and it makes any existing PRs difficult to apply. I'd definitely be okay with the |
Alright, I reverted back the f-strings changes. |
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
Although the name of this PR should probably be updated.
Nougat-Waffle
changed the title
5 participants
gh-94713: Replacing %-formatting and string concatenation with f-strings and replacing
while 1withwhile True.I don't think there is a need for a NEWS entry.