bpo-29905: Fix TypeError message formatting in asynchat and proactor_events#819
Closed
DimitrisJim wants to merge 2 commits intopython:masterfrom
DimitrisJim:fix_typeerror_format
Closed
bpo-29905: Fix TypeError message formatting in asynchat and proactor_events#819DimitrisJim wants to merge 2 commits intopython:masterfrom DimitrisJim:fix_typeerror_format
DimitrisJim wants to merge 2 commits intopython:masterfrom
DimitrisJim:fix_typeerror_format
Conversation
|
@DimitrisJim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tim-one, @josiahcarlson and @1st1 to be potential reviewers. |
Contributor
Author
|
Without being certain, the travis fail seems to be related to #743 that was merged a couple of days ago. Edit: Ok, seems like the fail was a one time thing. |
Contributor
Author
|
Hm, as per https://bugs.python.org/issue25002 I'll be retracting the change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.