bpo-29862: Fixed grammar error in TypeError exception message in reload function#809
Conversation
|
@mandeep, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @ericsnowcurrently and @ncoghlan to be potential reviewers. |
|
Looks good :) Thanks, @mandeep 🎉 |
|
@mandeep Could you add a test for this change? Thanks :) |
|
@Mariatta , we only assert the Exception Type, and we don't test the contents of the Exception Str. So, the change LGTM as it is. |
|
Ah ok, Thanks @orsenthil :) I thought we needed to get codecov green by adding test. In that case I can merge this. Still wondering whether this needs to be backported at all? |
|
Since it is a grammar / spell fix, backporting seems harmless to me. +1 if you were planning to do that. |
(cherry picked from commit 9f0aa48)
(cherry picked from commit 9f0aa48)
|
@Mariatta sorry I couldn't respond sooner. Thanks for submitting the backport changes. 😃 |
|
Thanks again @orsenthil and @mandeep :) |
5 participants
Fixed the grammar error found by Brett in the TypeError exception message on Line 140. All tests passed after making the change so I went ahead and created this pull request. If I need to add a test that checks the exception message, please let me know.