bpo-29861: release references to multiprocessing Pool tasks#743
bpo-29861: release references to multiprocessing Pool tasks#743pitrou merged 4 commits intopython:masterfrom
Conversation
Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives.
|
Note that, for some reason, the multiprocessing tests are excluded of the coverage runs, therefore codecov.io is complaining that my PR gets 0 coverage. @brettcannon might know more about this. |
|
The tests that are being skipped are due to the fact that they re-run a ton of tests that slows the whole coverage run down by a lot. It's possible I was overly aggressive or there's some flag to pass (or create) to minimize going overboard in the coverage report. |
|
I think you could improve the coverage runtimes by using gcc instead of clang. gcc uses |
|
The coverage build is non-debug: https://github.com/python/cpython/blob/master/.travis.yml#L55. As for switching it over to gcc, I'm fine with that (but that's off-topic for this PR and can be discussed in python/core-workflow#46). |
Oh, I see. The test suite is slow because it doesn't run in parallel mode. Switching to gcc wouldn't change anything then. |
|
@pitrou There might be a way to set it up to run in parallel and still correct the proper information, but I have not tried to make that work. |
* bpo-29861: release references to multiprocessing Pool tasks Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives. * Comments in test (cherry picked from commit 8988945)
* bpo-29861: release references to multiprocessing Pool tasks Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives. * Comments in test (cherry picked from commit 8988945)
) * bpo-29861: release references to multiprocessing Pool tasks (#743) * bpo-29861: release references to multiprocessing Pool tasks Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives. * Comments in test (cherry picked from commit 8988945) * Fix Misc/NEWS (hopefully)
) * bpo-29861: release references to multiprocessing Pool tasks (#743) * bpo-29861: release references to multiprocessing Pool tasks Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives. * Comments in test (cherry picked from commit 8988945) * Fix Misc/NEWS??
* bpo-29861: release references to multiprocessing Pool tasks Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives. * Comments in test (cherry picked from commit 8988945)
) * bpo-29861: release references to multiprocessing Pool tasks (#743) * bpo-29861: release references to multiprocessing Pool tasks Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives. * Comments in test (cherry picked from commit 8988945) * Fix Misc/NEWS ?
4 participants
Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives.