Implement the get_resource_reader() API for file system imports#5168
Implement the get_resource_reader() API for file system imports#5168warsaw merged 10 commits intopython:masterfrom
Conversation
|
@brettcannon I've moved the zipimport work to a separate branch, still in progress. |
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
It looks great overall, but we do need docs for this.
|
When you're done making the requested changes, leave the comment: |
|
@brettcannon Didn't you just land the docs for this in bca4218 ? |
|
I have made the requested changes; please review again |
|
@brettcannon Ping. I'm rebasing my zipimporter branch on top of this one, so I'd like to land it soon. See my previous comment about the docs. |
|
I landed the docs for the ABC, but I didn't document anything relating to the changes in this PR. I've gone ahead and approved this so you can get your zipimporter changes in as we can do doc changes in after b1 if necessary. |
4 participants
No description provided.