bpo-17852: Revert incorrect fix based on misunderstanding of _Py_PyAtExit() semantics#4826
Merged
vstinner merged 1 commit intopython:masterfrom Dec 13, 2017
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix committed in #3372 uses
_Py_PyAtExit. Unfortunately this function does not add a new callback, it merely replaces the current one. In other words,_Py_PyAtExitis only meant to be called by theatexitmodule and nothing else.https://bugs.python.org/issue17852