bpo-45548: Put Modules/Setup extensions into builddir#29188
Closed
tiran wants to merge 2 commits intopython:mainfrom
Closed
bpo-45548: Put Modules/Setup extensions into builddir#29188tiran wants to merge 2 commits intopython:mainfrom
tiran wants to merge 2 commits intopython:mainfrom
Conversation
Member
Author
|
7d58537 to
422f083
Compare
Modules/Setup used to put shared extensions into ``./Modules/`` directory. Now it puts the shared extensions in the same directory library directory ``./build/lib.$plat-$ver`` as distutils. The change makes the shared modules importable and fixes build issues. Signed-off-by: Christian Heimes <christian@python.org>
2d1df4c to
632bb41
Compare
Member
|
If this leaves draft and my review is still desired, please feel free to add me back. |
Member
Author
|
I have landed the fix with another commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules/Setup used to put shared extensions into
./Modules/directory. Now it puts the shared extensions in the same directory
library directory
./build/lib.$plat-$veras distutils.The change makes the shared modules importable and fixes build issues.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45548