X Tutup
Skip to content

[3.8] bpo-44849: Fix os.set_inheritable() on FreeBSD 14 with O_PATH (GH-27623)#28978

Merged
ambv merged 1 commit intopython:3.8from
miss-islington:backport-c24896c-3.8
Oct 19, 2021
Merged

[3.8] bpo-44849: Fix os.set_inheritable() on FreeBSD 14 with O_PATH (GH-27623)#28978
ambv merged 1 commit intopython:3.8from
miss-islington:backport-c24896c-3.8

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Oct 15, 2021

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue44849

…GH-27623)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner
Copy link
Copy Markdown
Member

The AMD64 FreeBSD Shared 3.8 buildbot is still up and running, but test_os.test_get_set_inheritable_o_path() fails:
https://buildbot.python.org/all/#/builders/555/builds/51

I propose to backport my fix to report the Python 3.8 FreeBSD buildbot.

@vstinner
Copy link
Copy Markdown
Member

cc @ambv

@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@ambv ambv merged commit 67e10be into python:3.8 Oct 19, 2021
@miss-islington miss-islington deleted the backport-c24896c-3.8 branch October 19, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup