Conversation
cclauss
requested review from
a team,
1st1,
abalkin,
asvetlov,
berkerpeksag,
cjw296,
ericvsmith,
ezio-melotti,
pganssle,
rhettinger,
terryjreedy and
vsajip
as code owners
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I checked everything, not just idlelib, and all the changes look correct. I checked a few with the handy web search bar. One other check will be sufficient.
The requested change is to change 'gui' to 'GUI' in a line with another correction.
If whoever merges this does not backport to both 3.10 and 3.9, please let me know as I want at least the idlelib changes backported and will do so if necessary.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
Except for the one small change I suggest, these all look good to me.
gpshead
added
needs backport to 3.9
needs backport to 3.10
|
There are ~5 of these PRs, see #28745 (comment) for details on how we're handling them. TL;DR - I'm taking the reviews. Backports to 3.9 and 3.10 are being done (manually) to reduce potential for merge conflicts of other bugfix backports. |
|
Sorry, @cclauss and @gpshead, I could not cleanly backport this to |
|
Sorry @cclauss and @gpshead, I had trouble checking out the |
Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 745c9d9)
|
GH-28803 is a backport of this pull request to the 3.9 branch. |
Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>. (cherry picked from commit 745c9d9) Co-authored-by: Christian Clauss <cclauss@me.com>
|
GH-28804 is a backport of this pull request to the 3.10 branch. |
Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
8 participants
Like #28744 but for the Lib directory.
[skip issue] Opening a related issue is pending python/psf-infra-meta#130
codespell --ignore-words-list=aline,alo,ans,asend,atleast,ba,bloc,browseable,cant,crasher,crashers,commen,datas,datea,doesnot,donn,ende,filetest,filetests,fiter,fo,hda,hel,hellow,henc,hist,infinit,inout,interruptable,invokations,ist,ket,lable,larg,leapyear,mye,nams,nd,ned,nin,notmutch,nwe,oder,oll,parm,raison,responsable,seh,simeple,squirl,spawnve,sur,tbe,te,teh,tey,thow,timere,tre,trough,tthe,ue,upto,wile,wont --skip=".decTest,.txt,*.types" Lib