X Tutup
Skip to content

fix one typo (from "yingyang" to "yinyang") # skip issue#2770

Merged
Mariatta merged 1 commit intopython:masterfrom
fanofxiaofeng:patch-1
Jul 20, 2017
Merged

fix one typo (from "yingyang" to "yinyang") # skip issue#2770
Mariatta merged 1 commit intopython:masterfrom
fanofxiaofeng:patch-1

Conversation

@fanofxiaofeng
Copy link
Copy Markdown
Contributor

@fanofxiaofeng fanofxiaofeng commented Jul 20, 2017

image

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jul 20, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot
Copy link
Copy Markdown

mention-bot commented Jul 20, 2017

@fanofxiaofeng, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @birkenfeld and @bitdancer to be potential reviewers.

@fanofxiaofeng fanofxiaofeng changed the title fix one typo (from "yingyang" to "yinyang") fix one typo (from "yingyang" to "yinyang") skip issue Jul 20, 2017
@fanofxiaofeng fanofxiaofeng changed the title fix one typo (from "yingyang" to "yinyang") skip issue fix one typo (from "yingyang" to "yinyang") # skip issue Jul 20, 2017
@fanofxiaofeng
Copy link
Copy Markdown
Contributor Author

fanofxiaofeng commented Jul 20, 2017

Hi~
I registered in b.g.o, please help me if there is still something wrong. Thanks a lot!

marco-buttu
marco-buttu approved these changes Jul 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@marco-buttu marco-buttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mariatta Mariatta added skip issue docs Documentation in the Doc dir needs backport to 2.7 labels Jul 20, 2017
@Mariatta Mariatta merged commit fff2a21 into python:master Jul 20, 2017
@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Jul 20, 2017

Thanks @fanofxiaofeng and congrats on your first contribution to CPython 🎉

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jul 20, 2017
@fanofxiaofeng @Mariatta
[3.6] Fix typo in Turtle Docs: yingyang -> yinyang (pythonGH-2770)
9335b3e 
(cherry picked from commit fff2a21)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jul 20, 2017
@fanofxiaofeng @Mariatta
[3.5] Fix typo in Turtle Docs: yingyang -> yinyang (pythonGH-2770)
723491e 
(cherry picked from commit fff2a21)
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 20, 2017

GH-2778 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jul 20, 2017
@fanofxiaofeng @Mariatta
[2.7] Fix typo in Turtle Docs: yingyang -> yinyang (pythonGH-2770)
40b82a8 
(cherry picked from commit fff2a21)
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 20, 2017

GH-2779 is a backport of this pull request to the 3.5 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 20, 2017

GH-2780 is a backport of this pull request to the 2.7 branch.

Mariatta added a commit that referenced this pull request Jul 20, 2017
@Mariatta
[3.6] Fix typo in Turtle Docs: yingyang -> yinyang (GH-2770) (GH-2778)
7f58994 
(cherry picked from commit fff2a21)
Mariatta added a commit that referenced this pull request Jul 20, 2017
@Mariatta
[3.5] Fix typo in Turtle Docs: yingyang -> yinyang (GH-2770) (GH-2779)
71d9b52 
(cherry picked from commit fff2a21)
Mariatta added a commit that referenced this pull request Jul 20, 2017
@Mariatta
[2.7] Fix typo in Turtle Docs: yingyang -> yinyang (GH-2770) (GH-2780)
598f26b 
(cherry picked from commit fff2a21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

+1 more reviewer

@marco-buttu marco-buttu marco-buttu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fanofxiaofeng @the-knights-who-say-ni @mention-bot @Mariatta @bedevere-bot @marco-buttu
X Tutup