bpo-38435: Detect preexec_fn=os.setsid as start_new_session=True#23936
Closed
gpshead wants to merge 1 commit intopython:mainfrom
Closed
bpo-38435: Detect preexec_fn=os.setsid as start_new_session=True#23936gpshead wants to merge 1 commit intopython:mainfrom
gpshead wants to merge 1 commit intopython:mainfrom
Conversation
This is a somewhat common use case, this makes it more reliable.
gpshead
added
type-feature
izbyshev
reviewed
Dec 26, 2020
Contributor
izbyshev
left a comment
izbyshev
left a comment
There was a problem hiding this comment.
Is your intent to keep this for reducing compat breakage after real preexec_fn support is removed? Otherwise, it seems like having preexec_fn=os.sid perform slower and less reliably would be more helpful in motivating users to migrate to start_new_session :)
|
This PR is stale because it has been open for 30 days with no activity. |
Member
Author
|
this special case won't do a lot as it is one of many. we need to solve the greater problem of providing a way for all actually needed actions to be taken before exec. abandoning this mini idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a somewhat common use case, this makes it more reliable.
I'd rather see code that does this be cleaned up. But until it is, this at least makes it more reliable and a little faster.
https://bugs.python.org/issue38435