X Tutup
Skip to content

bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure#23708

Merged
pablogsal merged 2 commits intopython:masterfrom
mattip:ext_suffix2
Dec 20, 2020
Merged

bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure#23708
pablogsal merged 2 commits intopython:masterfrom
mattip:ext_suffix2

Conversation

@mattip
Copy link
Copy Markdown
Contributor

@mattip mattip commented Dec 8, 2020 •
edited by miss-islington
Loading

Continuation of bpo 39825 which was fixed for windows in gh-22088. This fix is for non-linux systems like FreeBSD and AIX. Merging gh-22088 added a test which fails on FreeBSD and AIX:

FAIL: test_EXT_SUFFIX_in_vars (test.test_sysconfig.TestSysConfig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test_sysconfig.py", line 368, in \
               test_EXT_SUFFIX_in_vars
    self.assertEqual(vars['EXT_SUFFIX'], _imp.extension_suffixes()[0])
AssertionError: '.so' != '.cpython-310d.so'
- .so
+ .cpython-310d.so

So EXT_SUFFIX is being set to .so rather than .cpython-310d.so. This is wrong, EXT_SUFFIX is expected to be .cpython-310d.so in this case.

The difference in EXT_SUFFIX comes from this stanza in configure and configure.ac:

case $ac_sys_system in
    Linux*|GNU*|Darwin|VxWorks)
	EXT_SUFFIX=.${SOABI}${SHLIB_SUFFIX};;
    *)
	EXT_SUFFIX=${SHLIB_SUFFIX};;
esac

where $ac_sys_system is uname -s. On FREEBSD, this is FreeBSD, and I think on AIX it is AIX. This stanza was in the original version of the files, I am not sure why the original author differentiated between the two values for EXT_SUFFIX.

https://bugs.python.org/issue42604

@mattip mattip mentioned this pull request Dec 8, 2020
Closed
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 20, 2020
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 20, 2020

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 75e9b23 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 20, 2020
@pablogsal pablogsal self-assigned this Dec 20, 2020
@pablogsal pablogsal requested a review from vstinner December 20, 2020 02:06
@pablogsal pablogsal merged commit a44ce6c into python:master Dec 20, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 20, 2020

Thanks @mattip for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 20, 2020

GH-23866 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 20, 2020

GH-23867 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2020
@mattip @miss-islington
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using c…
dbc95a1 
…onfigure (pythonGH-23708)

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
(cherry picked from commit a44ce6c)

Co-authored-by: Matti Picus <matti.picus@gmail.com>
miss-islington added a commit that referenced this pull request Dec 20, 2020
@miss-islington @mattip
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using c…
b01091a 
…onfigure (GH-23708)

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
(cherry picked from commit a44ce6c)

Co-authored-by: Matti Picus <matti.picus@gmail.com>
pablogsal pushed a commit that referenced this pull request Dec 20, 2020
@miss-islington @mattip
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using c…
4b15596 
…onfigure (GH-23708) (GH-23866)

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
(cherry picked from commit a44ce6c)

Co-authored-by: Matti Picus <matti.picus@gmail.com>

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@kulikjak kulikjak mentioned this pull request Dec 21, 2020
Closed
@fochoao
Copy link
Copy Markdown

fochoao commented Dec 29, 2020

The code can be made with a function with tuples or lists, instead of writing the same 5 or 6 times.

@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented Dec 29, 2020

The code can be made with a function with tuples or lists, instead of writing the same 5 or 6 times.

I think you may have written in the wrong issue/PR

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@mattip @pablogsal @adorilson
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using c…
5434bdc 
…onfigure (pythonGH-23708)

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
@fochoao
Copy link
Copy Markdown

fochoao commented May 6, 2021

The code can be made with a function with tuples or lists, instead of writing the same 5 or 6 times.
I think you may have written in the wrong issue/PR

Yes, it was the wrong project...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mattip @bedevere-bot @miss-islington @fochoao @pablogsal @the-knights-who-say-ni
X Tutup