X Tutup
Skip to content

bpo-30709: bad getter from Descriptor#Properties example#2288

Closed
anqur wants to merge 3380 commits intopython:2.7from
anqur:patch-1
Closed

bpo-30709: bad getter from Descriptor#Properties example#2288
anqur wants to merge 3380 commits intopython:2.7from
anqur:patch-1

Conversation

@anqur
Copy link
Copy Markdown
Contributor

@anqur anqur commented Jun 20, 2017

  • The purpose of obj in the example is implicit
  • As an argument the obj will cause errors when using Cell('b10').value because it expects more arguments, but 1 given

brettcannon and others added 30 commits December 22, 2016 10:03
WeakValueDictionary when collecting from another thread.
….textpad.Textbox.

Based on patch by Tycho Andersen.
…ject and modes

"w" now are relative to the start of the file.
…ode.

Patch by jan matejek and Xiang Zhang.
In urllib, suffixes in no_proxy environment variable with
leading dots could match related hostnames again (e.g. .b.c matches a.b.c).
Patch by Milan Oberkirch.
Issue python#29188: Support glibc 2.24 on Linux: don't use getentropy() function but
read from /dev/urandom to get random bytes, for example in os.urandom().  On
Linux, getentropy() is implemented which getrandom() is blocking mode, whereas
os.urandom() should not block.
matrixise and others added 14 commits June 12, 2017 15:30
PyNumber_Int() creates a new reference: need to decrement result
reference counter.
Add a test to check the current MAGIC_NUMBER against the
expected number for the release if the current release is
at candidate or final level. On test failure, describe to
the developer the procedure for changing the magic number.

This ensures that pre-merge CI will automatically pick up
on magic number changes in maintenance releases (and
explain why those are problematic), rather than relying on
all core developers to be aware of the implications of
such changes.
…honGH-2159) (python#2168)

* bpo-24484: Avoid race condition in multiprocessing cleanup

The finalizer registry can be mutated while inspected by multiprocessing
at process exit.

* Use test.support.start_threads()

* Add Misc/NEWS.
(cherry picked from commit 1eb6c00)
…nGH-2190)

Replace platform with platforms.
(cherry picked from commit 4ebf03d)
…n#2202)

* bpo-29591: Upgrade Modules/expat to libexpat 2.2

* bpo-29591: Restore Python changes on expat

* bpo-29591: Remove expat config of unsupported platforms

Remove the configuration (Modules/expat/*config.h) of unsupported
platforms:

* Amiga
* MacOS Classic on PPC32
* Open Watcom

* bpo-29591: Remove useless XML_HAS_SET_HASH_SALT

The XML_HAS_SET_HASH_SALT define of Modules/expat/expat.h became
useless since our local expat copy was upgrade to expat 2.1 (it's now
expat 2.2.0).

(cherry picked from commit 23ec4b5)
regrtest now warms up caches: create explicitly all internal
singletons which are created on demand to prevent false positives
when checking for reference leaks.
…rtest (python#2249)

[2.7] bpo-30540, bpo-30523: Add --matchfile and --list-cases options to regrtest
- The purpose of `obj` in the example is implicit
- As an argument the `obj` will cause errors when using `Cell('b10').value` because it expects more arguments, but 1 given
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@anqur anqur changed the title Bad getter from Descriptor#Properties example trivial - bad getter from Descriptor#Properties example Jun 20, 2017
@anqur anqur changed the title trivial - bad getter from Descriptor#Properties example bpo30709 - bad getter from Descriptor#Properties example Jun 20, 2017
@anqur anqur changed the title bpo30709 - bad getter from Descriptor#Properties example bpo-30709: bad getter from Descriptor#Properties example Jun 20, 2017
@anqur
Copy link
Copy Markdown
Contributor Author

anqur commented Jun 20, 2017

Oops sorry for some mess here I'm just kinda new in this amazing community 🙏

Copy link
Copy Markdown
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I noticed you made this against the 2.7 branch. Can you make the change against the master branch first? Once the PR on master has been merged, it can be backported to the maintenance branches.

@anqur anqur changed the base branch from 2.7 to master June 21, 2017 16:09
@anqur
Copy link
Copy Markdown
Contributor Author

anqur commented Jun 21, 2017

@Mariatta Thanks for your reply! I just updated the base branch!

@Mariatta
Copy link
Copy Markdown
Member

Simply changing the base branch on GitHub won't work :(

I think you'll need to rebase against the master branch, and then do a force push.

Perhaps it will be easier for you to checkout a branch that is off the master branch, eg by doing git checkout -b <branchname> master, make your edit in that branch, commit and push.

@anqur
Copy link
Copy Markdown
Contributor Author

anqur commented Jun 22, 2017

@Mariatta I'm pretty sorry for my misconception, and perhaps it is heavily due to my direct modification on that file via GitHub webpage, which creates a new patch-1 branch and simply breaks the normal workflow of this repo itself.

I'm closing this and will new a PR with a link to this conversation. And I will clone my forked repo (which is much outdated seemingly) and use the following commands to make my changes against master branch:

$ # New branch `foo'
$ git fetch origin # updates origin/master
$ # make my changes on `foo'
$ git rebase origin/master
$ git push origin master -f
$ # New a pull request on python/cpython

Hope it works out...

@anqur anqur closed this Jun 23, 2017
@anqur anqur deleted the patch-1 branch June 23, 2017 03:39
@Mariatta Mariatta changed the base branch from master to 2.7 June 23, 2017 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

X Tutup