X Tutup
Skip to content

bpo-29933: improving set_write_buffer_limits description#2262

Merged
Mariatta merged 4 commits intopython:masterfrom
kojoidrissa:master
Jun 20, 2017
Merged

bpo-29933: improving set_write_buffer_limits description#2262
Mariatta merged 4 commits intopython:masterfrom
kojoidrissa:master

Conversation

@kojoidrissa
Copy link
Copy Markdown
Contributor

@kojoidrissa kojoidrissa commented Jun 18, 2017

Improved the description of the high and low parameters for set_write_buffer_limits. Also fixed a small grammatical issue.

@mention-bot
Copy link
Copy Markdown

mention-bot commented Jun 18, 2017

@kojoidrissa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @berkerpeksag and @methane to be potential reviewers.

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jun 18, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@kojoidrissa kojoidrissa changed the title addressing issue29933#msg290712 bpo-29933: improving set_write_buffer_limits description Jun 18, 2017
@Mariatta Mariatta added docs Documentation in the Doc dir needs backport to 3.5 labels Jun 18, 2017
@Mariatta Mariatta requested a review from vstinner June 18, 2017 04:51
@Mariatta Mariatta merged commit 5200a7c into python:master Jun 20, 2017
@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Jun 20, 2017

Thanks @kojoidrissa and congrats on your first contribution to CPython 🎉
Can you backport this to 3.6 and 3.5 branches?

If you have Python 3.6 installed, then you can use cherry_picker.py

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jun 28, 2017

Can you backport this to 3.6 and 3.5 branches?

Can someone please backport these changes? @kojoidrissa maybe?

@kojoidrissa
Copy link
Copy Markdown
Contributor Author

kojoidrissa commented Jun 28, 2017 via email

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 2, 2017

GH-2532 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 2, 2017

GH-2533 is a backport of this pull request to the 3.5 branch.

Mariatta pushed a commit that referenced this pull request Jul 2, 2017
@kojoidrissa @Mariatta
[3.5] bpo-29933: Improve set_write_buffer_limits description (GH-2262) (
4685e56 
GH-2533)

Improve the description of the high and low parameters for set_write_buffer_limits.
Also fixed a small grammatical issue.
(cherry picked from commit 5200a7c)
Mariatta pushed a commit that referenced this pull request Jul 2, 2017
@kojoidrissa @Mariatta
[3.6] bpo-29933: Improve set_write_buffer_limits description (GH-2262) (
03af428 
GH-2532)

Improve the description of the high and low parameters for set_write_buffer_limits.
Also fixed a small grammatical issue.
(cherry picked from commit 5200a7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kojoidrissa @mention-bot @the-knights-who-say-ni @Mariatta @vstinner @bedevere-bot
X Tutup