[3.8] bpo-41302: Support system libmpdec 2.5 for Python 3.8#21488
[3.8] bpo-41302: Support system libmpdec 2.5 for Python 3.8#21488skrah merged 2 commits intopython:3.8from
Conversation
Define UNUSED only when mpdecimal.h doesn't define it. This would support building with system libmpdec 2.5 while retaining compatibility with system libmpdec 2.4 or the vendored copy. Tested to build fine with either system libmpdec or the vendored one.
skrah
left a comment
skrah
left a comment
There was a problem hiding this comment.
Thank you, this looks very safe given that neither _decimal.c nor libmpdec will change in 3.8.
Could you add a News entry to justify this? Something like:
"Enable building Python 3.8 with libmpdec-2.5.0 to ease maintenance for Linux distributions. Patch by Felix Yan."
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
felixonmars
changed the title
|
I have made the requested changes; please review again. (Used blurb_t for the first time, hopefully I did it right) |
|
Thanks for making the requested changes! @skrah: please review the changes made to this pull request. |
|
Even though the patch is obviously correct, I've tested this with the included |
4 participants
Define UNUSED only when mpdecimal.h doesn't define it. This would support
building with system libmpdec 2.5 while retaining compatibility with system
libmpdec 2.4 or the vendored copy.
Tested to build fine with either system libmpdec or the vendored one.
https://bugs.python.org/issue41302