bpo-30615: Fix the leak reference in Modules/_elementtree.c#2129
Merged
vstinner merged 1 commit intopython:2.7from Jun 12, 2017
Merged
bpo-30615: Fix the leak reference in Modules/_elementtree.c#2129vstinner merged 1 commit intopython:2.7from
vstinner merged 1 commit intopython:2.7from
Conversation
vstinner
requested changes
Jun 12, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
This change it wrong: don't call Py_ReprLeave() is status > 0.
Member
Author
|
that's the reason of my request for the review, I wanted to know if we need to call |
Member
|
There is https://docs.python.org/dev/c-api/exceptions.html#c.Py_ReprEnter doc, it may help. |
vstinner
requested changes
Jun 12, 2017
Modules/_elementtree.c
Outdated
Member
There was a problem hiding this comment.
Py_ReprLeave() must only be called if Py_ReprEnter() succeeded: status == 0.
vstinner
approved these changes
Jun 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.