X Tutup
Skip to content

Use Travis to make sure all generated files are up to date#2080

Merged
zware merged 7 commits intopython:masterfrom
zware:travis_regen
Jun 11, 2017
Merged

Use Travis to make sure all generated files are up to date#2080
zware merged 7 commits intopython:masterfrom
zware:travis_regen

Conversation

@zware
Copy link
Copy Markdown
Member

@zware zware commented Jun 10, 2017

If this works as expected, it should effectively address python/core-workflow#118, unless we really want it as a separate check.

@zware zware requested a review from serhiy-storchaka June 10, 2017 16:39
@mention-bot
Copy link
Copy Markdown

mention-bot commented Jun 10, 2017

@zware, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @berkerpeksag and @dstufft to be potential reviewers.

@zware zware added the trivial label Jun 10, 2017
ncoghlan
ncoghlan approved these changes Jun 11, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I see from the commit history that you've checked to ensure it actually fails CI when provoked :)

Another useful thing this will check is cherry-picked regenerated files - those where the changes have been brought in from master (e.g. by cherry_pick.py), rather than the regeneration being run on the target branch.

@zware
Copy link
Copy Markdown
Member Author

zware commented Jun 11, 2017

Thanks, Nick! As @serhiy-storchaka already gave approval of at least the approach on IRC, I'll go ahead and merge.

@zware zware merged commit 0afbabe into python:master Jun 11, 2017
@zware zware deleted the travis_regen branch June 11, 2017 02:37
zware added a commit to zware/cpython that referenced this pull request Jun 11, 2017
@zware
[3.6] Use Travis to make sure all generated files are up to date (pyt…
e45c52b 
…honGH-2080)

(cherry picked from commit 0afbabe)
zware added a commit to zware/cpython that referenced this pull request Jun 11, 2017
@zware
[3.5] Use Travis to make sure all generated files are up to date (pyt…
d532fdb 
…honGH-2080)

(cherry picked from commit 0afbabe)
zware added a commit that referenced this pull request Jun 11, 2017
@zware
[3.6] Use Travis to make sure all generated files are up to date (GH-…
f57e34b 
…2080) (GH-2092)

(cherry picked from commit 0afbabe)

Also fixes some line endings missed in GH-840 backport.
zware added a commit that referenced this pull request Jun 11, 2017
@zware
[3.5] Use Travis to make sure all generated files are up to date (GH-…
80bdbf6 
…2080) (GH-2093)

(cherry picked from commit 0afbabe)

Also fixes some line endings missed in GH-840 backport.
zware added a commit to zware/cpython that referenced this pull request Jun 11, 2017
@zware
Use Travis to make sure all generated files are up to date (pythonGH-…
0809d07 
…2080)
zware added a commit that referenced this pull request Jun 11, 2017
@zware
[2.7] Use Travis to make sure all generated files are up to date (GH-…
51658f7 
…2080) (GH-2094)

(cherry-picked from commit 0afbabe)

Also adds `python.exe-gdb.py` to `.gitignore`, it is created by OS X builds.
@zware zware mentioned this pull request Jun 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zware @mention-bot @ncoghlan @the-knights-who-say-ni
X Tutup