bpo-40882: Fix a memory leak in SharedMemory on Windows by ZackerySpytz · Pull Request #20684 · python/cpython

ZackerySpytz · 2020-06-06T21:38:28Z

In multiprocessing.shared_memory.SharedMemory(), the temporary view
returned by MapViewOfFile() should be unmapped when it is no longer
needed.

https://bugs.python.org/issue40882

In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed.

csabella · 2020-06-12T22:25:12Z

@zooba, should this be merged? Thanks!

lukegarland · 2021-08-27T19:10:02Z

@zooba
Hi there, are there any plans to have this merged in with the main branch, and be available in a stable version of Python? Would like to know the timeline if possible.

Thanks,
Luke Garland

iritkatriel · 2022-11-25T11:30:34Z

@ZackerySpytz This has merge conflicts now.

…82-mp-SharedMemory-leak-win

kumaraditya303 · 2022-11-25T11:52:25Z

I fixed the merge conflicts.

miss-islington · 2022-11-25T17:40:04Z

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington · 2022-11-25T17:40:04Z

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington · 2022-11-25T17:40:09Z

Sorry, @ZackerySpytz and @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 85c128e34daec7625b74746e127afa25888ccde1 3.10

miss-islington · 2022-11-25T17:40:11Z

Sorry @ZackerySpytz and @zooba, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 85c128e34daec7625b74746e127afa25888ccde1 3.11

miss-islington · 2022-11-25T17:40:29Z

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington · 2022-11-25T17:40:42Z

Sorry, @ZackerySpytz and @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 85c128e34daec7625b74746e127afa25888ccde1 3.11

zooba · 2022-11-25T17:43:01Z

Any volunteers to do the backport? I've got too many other things checked out right now to do it

…nGH-20684) In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed.. (cherry picked from commit 85c128e) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

lukegarland · 2022-11-30T22:08:10Z

Here it is for Python 3.10 #99911

bedevere-bot · 2022-12-01T00:43:29Z

GH-99911 is a backport of this pull request to the 3.10 branch.

…nGH-20684) In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed.. (cherry picked from commit 85c128e) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

…nGH-20684) In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed. (cherry picked from commit 85c128e) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed. (cherry picked from commit 85c128e) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed. (cherry picked from commit 85c128e)

bedevere-bot · 2022-12-03T18:09:41Z

GH-99973 is a backport of this pull request to the 3.11 branch.

lukegarland · 2022-12-03T18:10:40Z

Backport for 3.11 is here: #99973

) (#99973) bpo-40882: Fix a memory leak in SharedMemory on Windows (GH-20684) In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed. (cherry picked from commit 85c128e) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

bpo-40882: Fix a memory leak in SharedMemory on Windows

8537886

In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed.

ZackerySpytz requested a review from tiran as a code owner June 6, 2020 21:38

the-knights-who-say-ni added the CLA signed label Jun 6, 2020

bedevere-bot added the awaiting review label Jun 6, 2020

zooba approved these changes Jun 10, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jun 10, 2020

tiran removed their request for review April 18, 2021 09:50

eryksun mentioned this pull request Apr 10, 2022

[multiprocessing] memory leak in shared_memory.SharedMemory in Windows #85059

Closed

ezio-melotti removed the CLA signed label Jul 13, 2022

Merge branch 'main' of https://github.com/python/cpython into bpo-408…

31980e5

…82-mp-SharedMemory-leak-win

kumaraditya303 requested a review from zooba November 25, 2022 11:53

kumaraditya303 assigned zooba Nov 25, 2022

kumaraditya303 added the topic-multiprocessing label Nov 25, 2022

clinic regen

0579ae3

zooba merged commit 85c128e into python:main Nov 25, 2022

bedevere-bot removed the awaiting merge label Nov 25, 2022

zooba added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 25, 2022

zooba added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Nov 25, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 1, 2022

lukegarland mentioned this pull request Dec 1, 2022

[3.10] bpo-40882: Fix a memory leak in SharedMemory on Windows (GH-20684) #99911

Merged

lukegarland mentioned this pull request Dec 3, 2022

[3.11] bpo-40882: Fix a memory leak in SharedMemory on Windows (GH-20684) #99973

Merged

bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 3, 2022

devilsnare007 mentioned this pull request Aug 19, 2023

Port the fix for memory leak in Shared Memory on Windows when unlinking mars-project/shared_memory38#6

Closed

wjsi mentioned this pull request Sep 15, 2023

Port from PR 91579 and PR 20684 in Python mars-project/shared_memory38#7

Merged

This was referenced Dec 20, 2025

Add missing winapi function numpy/numpy#30488

Closed

Add missing _winapi.UnmapViewOfFile pypy/pypy#5361

Open

Uh oh!

Conversation

ZackerySpytz commented Jun 6, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csabella commented Jun 12, 2020

Uh oh!

lukegarland commented Aug 27, 2021

Uh oh!

iritkatriel commented Nov 25, 2022

Uh oh!

kumaraditya303 commented Nov 25, 2022

Uh oh!

miss-islington commented Nov 25, 2022

Uh oh!

miss-islington commented Nov 25, 2022

Uh oh!

miss-islington commented Nov 25, 2022

Uh oh!

miss-islington commented Nov 25, 2022

Uh oh!

miss-islington commented Nov 25, 2022

Uh oh!

miss-islington commented Nov 25, 2022

Uh oh!

zooba commented Nov 25, 2022

Uh oh!

lukegarland commented Nov 30, 2022

Uh oh!

bedevere-bot commented Dec 1, 2022

Uh oh!

bedevere-bot commented Dec 3, 2022

Uh oh!

lukegarland commented Dec 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ZackerySpytz commented Jun 6, 2020 •

edited by bedevere-bot

Loading