bpo-31033: Add a msg argument to Future.cancel() and Task.cancel()#19979
Merged
cjerdonek merged 8 commits intopython:masterfrom May 15, 2020
Merged
bpo-31033: Add a msg argument to Future.cancel() and Task.cancel()#19979cjerdonek merged 8 commits intopython:masterfrom
cjerdonek merged 8 commits intopython:masterfrom
Conversation
cjerdonek
force-pushed
the
issue-31033-cancel-msg
branch
3 times, most recently
from
67ba96f to
de9f8b1
Compare
cjerdonek
changed the title
cjerdonek
force-pushed
the
issue-31033-cancel-msg
branch
5 times, most recently
from
ff02c76 to
6a21d74
Compare
1st1
reviewed
May 13, 2020
cjerdonek
force-pushed
the
issue-31033-cancel-msg
branch
from
6a21d74 to
50cf2a8
Compare
Member
Author
|
@1st1 I removed the exception helper like you requested (inlining the logic instead, like you suggested). Can you take another look? |
cjerdonek
force-pushed
the
issue-31033-cancel-msg
branch
from
50cf2a8 to
22a54cc
Compare
Member
Author
|
Force-pushed to unstick CI.. |
1st1
reviewed
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
msgargument toFuture.cancel()andTask.cancel().(The C implementation is currently working and tests are added, but I still need to do the pure Python implementation.)
https://bugs.python.org/issue31033