X Tutup
Skip to content

bpo-40434: Update the reason why CPython doesn't have switch statements#19787

Closed
amaajemyfren wants to merge 2 commits intopython:masterfrom
amaajemyfren:design_faq
Closed

bpo-40434: Update the reason why CPython doesn't have switch statements#19787
amaajemyfren wants to merge 2 commits intopython:masterfrom
amaajemyfren:design_faq

Conversation

@amaajemyfren
Copy link
Copy Markdown
Contributor

@amaajemyfren amaajemyfren commented Apr 29, 2020

@amaajemyfren
Copy link
Copy Markdown
Contributor Author

Thanks @remilapeyre for the approval. Kindly add the skip news label and advise on the next steps please.

Thank you.

@remilapeyre
Copy link
Copy Markdown

remilapeyre commented Apr 29, 2020

Kindly add the skip news label and advise on the next steps please.

The skip news label will be added by a core developer that will make a second review of your PR and either ask for some changes or merge it :)

Copy link
Copy Markdown
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amaajemyfren , I commented on bpo but decided to put the same thought here. I understand the change but curious what is your reasoning on referencing just one of the PEPs and not both of them?

@amaajemyfren
Copy link
Copy Markdown
Contributor Author

amaajemyfren commented May 1, 2020

Hi @nanjekyejoanna,

the statement initially said that there was no consensus yet on how to do range tests. This is not true because there is now a decision to not do range tests - that decision is only in PEP 3103 and not in PEP 275 (PEP 275 actually links to PEP 3103 to explain why it is rejected). My feeling is that putting two references complicates the goal of explaining it.

That said there is also this but that may still be a while away.

Copy link
Copy Markdown
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP 275 actually links to PEP 3103 to explain why it is rejected

Well, am not very convinced if consensus was reached on range tests so I will refrain for someone else's opinion as it is not as apparent to me yet.

@vstinner vstinner closed this May 3, 2021
@vstinner vstinner deleted the branch python:master May 3, 2021 21:29
@iritkatriel iritkatriel requested a review from CAM-Gerlach April 3, 2023 22:16
@CAM-Gerlach
Copy link
Copy Markdown
Member

@iritkatriel Was this an accident? Seems like the section has been substantially updated, with these sentences eliminated and replaced with information about the new match statement.

@iritkatriel
Copy link
Copy Markdown
Member

Thanks for checking and closing.

@CAM-Gerlach
Copy link
Copy Markdown
Member

(N.B., Victor closed it 2 years ago, not me :)

@iritkatriel
Copy link
Copy Markdown
Member

Ah, I thought this was the issue - I guess we can close that now: #84614

@CAM-Gerlach
Copy link
Copy Markdown
Member

Ah, gotcha—didn't see the linked issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

X Tutup