bpo-30557: faulthandler now correctly filters and displays exception codes on Windows#1924
Merged
zooba merged 4 commits intopython:masterfrom Jun 5, 2017
Merged
bpo-30557: faulthandler now correctly filters and displays exception codes on Windows#1924zooba merged 4 commits intopython:masterfrom
zooba merged 4 commits intopython:masterfrom
Conversation
zooba
added
needs backport to 3.5
OS-windows
type-bug
vstinner
reviewed
Jun 2, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Would it be possible to write an unit test for filtered exception? It's not a requirement, just a question.
Modules/faulthandler.c
Outdated
| @@ -374,7 +374,7 @@ faulthandler_exc_handler(struct _EXCEPTION_POINTERS *exc_info) | |||
| DWORD flags = exc_info->ExceptionRecord->ExceptionFlags; | |||
|
|
|||
| /* only log fatal exceptions */ | |||
Member
There was a problem hiding this comment.
Please add bpo number to this comment.
Member
Author
|
@Haypo Should be able to - the RaiseException function should let us raise with any code we like. Or perhaps I can figure out the call that brought this problem to light and make that one. |
Member
|
Ah yes, using RaiseException() and check that faulthandler didn't log
anything is a good plan
|
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Jun 5, 2017
…codes on Windows (python#1924) * bpo-30557: faulthandler now correctly filters and displays exception codes on Windows * Adds test for non-fatal exceptions. * Adds bpo number to comment.
Member
Author
|
Doesn't actually need a backport to 3.5, since the affected code doesn't appear to be there. |
zooba
added a commit
that referenced
this pull request
Jun 6, 2017
…ption … (#1960) * bpo-30557: faulthandler now correctly filters and displays exception codes on Windows (#1924) * bpo-30557: faulthandler now correctly filters and displays exception codes on Windows * Adds test for non-fatal exceptions. * Adds bpo number to comment. * bpo-30557: Fix test_faulthandler (#1969) On Windows 8, 8.1 and 10 at least, the exit code is the exception code (no bit is cleared).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-30557: faulthandler now correctly filters and displays exception codes on Windows