X Tutup
Skip to content

bpo-30470: Deprecate invalid ctypes call protection on Windows.#1810

Merged
Mariatta merged 2 commits intopython:masterfrom
Mariatta:deprecate-ctypes
May 27, 2017
Merged

bpo-30470: Deprecate invalid ctypes call protection on Windows.#1810
Mariatta merged 2 commits intopython:masterfrom
Mariatta:deprecate-ctypes

Conversation

@Mariatta
Copy link
Copy Markdown
Member

@Mariatta Mariatta commented May 25, 2017

Calling Ctypes functions is deprecated in 3.6.2 and will be removed in 3.7

@Mariatta Mariatta added the docs Documentation in the Doc dir label May 25, 2017
@mention-bot
Copy link
Copy Markdown

mention-bot commented May 25, 2017

@Mariatta, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @theller to be potential reviewers.

@Mariatta
Copy link
Copy Markdown
Member Author

Mariatta commented May 25, 2017

@zooba @Haypo or @ned-deily can one of you review please? I'm not sure if I'm doing this right. Thanks :)

Syeberman
Syeberman reviewed May 25, 2017
View reviewed changes
Doc/library/ctypes.rst Outdated
Copy link
Copy Markdown

@Syeberman Syeberman May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment suggests that ctypes functions cannot be called, i.e. that the GetModuleHandleA() call in the next paragraph will soon be unsupported.

Perhaps move this deprecation warning down below the "ctypes tries to protect you from calling functions with the wrong number of arguments" paragraph (line 164/170) and reword as "This protection against incorrect arguments is deprecated and will be removed."

Copy link
Copy Markdown
Member

@zooba zooba May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'd get really specific here with something like "Calling ctypes functions with incorrect arguments, either number or type, is unsupported and may no longer raise a ValueError."

It might even make more sense to insert the note directly above the paragraph below that says "ctypes tries to protect you...". Or just remove that section and add a note saying "ctypes may raise a ValueError after calling the function if it detects that an invalid number of arguments were passed. This behavior is deprecated, should not be relied upon, and will be removed in Python 3.7"

@Mariatta
Copy link
Copy Markdown
Member Author

Mariatta commented May 27, 2017

Thanks @Syeberman and @zooba. I made the change as you suggested. Please check.
I'll resolve the conflict once you're ok with this change.

Mariatta added 2 commits May 26, 2017 22:10
@Mariatta
bpo-30470: Deprecate invalid ctypes call protection on Windows.
9f5e8c3 
Calling Ctypes functions is deprecated in 3.6.2 and will be removed in 3.7
@Mariatta
move the note to the bottom
e53e4d0
@Mariatta Mariatta force-pushed the deprecate-ctypes branch from 38036f5 to e53e4d0 Compare May 27, 2017 05:10
@Mariatta
Copy link
Copy Markdown
Member Author

Mariatta commented May 27, 2017

Resolved the conflict

@Syeberman
Copy link
Copy Markdown

Syeberman commented May 27, 2017

LGTM

@Mariatta Mariatta merged commit f931fd1 into python:master May 27, 2017
@Mariatta Mariatta deleted the deprecate-ctypes branch May 27, 2017 14:23
Mariatta added a commit to Mariatta/cpython that referenced this pull request May 27, 2017
@Mariatta
[3.6] bpo-30470: Deprecate invalid ctypes call protection on Windows. (…
bc4f4f2 
…pythonGH-1810)

Calling Ctypes functions is deprecated in 3.6.2 and will be removed in 3.7.
(cherry picked from commit f931fd1)
@Mariatta Mariatta mentioned this pull request May 27, 2017
Merged
Mariatta added a commit that referenced this pull request May 27, 2017
@Mariatta
[3.6] bpo-30470: Deprecate invalid ctypes call protection on Windows. (…
2ee91c8 
…GH-1810) (GH-1833)

Calling Ctypes functions is deprecated in 3.6.2 and will be removed in 3.7.
(cherry picked from commit f931fd1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

+1 more reviewer

@Syeberman Syeberman Syeberman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mariatta @mention-bot @Syeberman @zooba @the-knights-who-say-ni
X Tutup