[3.8] bpo-38469: Handle named expression scope with global/nonlocal keywords (GH-16755)#16760
Merged
ambv merged 1 commit intopython:3.8from Oct 14, 2019
Merged
Conversation
pythonGH-16755) The symbol table handing of PEP572's assignment expressions is not resolving correctly the scope of some variables in presence of global/nonlocal keywords in conjunction with comprehensions. (cherry picked from commit fd5c414) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Member
|
@ambv Please, evaluate if we should merge this bugfix backport before the release or we should instead wait for 3.8.1. Check the issue discussion for more context. |
Contributor
Author
|
@pablogsal: Status check is done, and it's a success ✅ . |
2 similar comments
Contributor
Author
|
@pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@pablogsal: Status check is done, and it's a success ✅ . |
|
@ambv: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol table handing of PEP572's assignment expressions is not resolving correctly the scope of some variables in presence of global/nonlocal keywords in conjunction with comprehensions.
(cherry picked from commit fd5c414)
Co-authored-by: Pablo Galindo Pablogsal@gmail.com
https://bugs.python.org/issue38469