X Tutup
Skip to content

bpo-38034: Fix typo in logging.handlers.rst#15708

Merged
willingc merged 1 commit intopython:masterfrom
wwuck:tomascassidy-patch-1
Sep 11, 2019
Merged

bpo-38034: Fix typo in logging.handlers.rst#15708
willingc merged 1 commit intopython:masterfrom
wwuck:tomascassidy-patch-1

Conversation

@wwuck
Copy link
Copy Markdown
Contributor

@wwuck wwuck commented Sep 6, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Sep 6, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 6, 2019
tirkarthi
tirkarthi approved these changes Sep 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

corona10
corona10 approved these changes Sep 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomascassidy Looks good to me. Could you like to sign the CLA, please?

@corona10
Copy link
Copy Markdown
Member

corona10 commented Sep 7, 2019 •
edited
Loading

@vsajip
This PR looks good to me.
Can you please take a look this PR as the core developer?
cc @vstinner

@vsajip
Copy link
Copy Markdown
Member

vsajip commented Sep 9, 2019

Yes, the patch is fine, and can be merged once the CLA is signed.

@willingc
Copy link
Copy Markdown
Contributor

willingc commented Sep 11, 2019

Thanks @wwuck for the PR and @corona10 and @vsajip for the reviews.

@willingc willingc merged commit efd5741 into python:master Sep 11, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 11, 2019

Thanks @wwuck for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2019

GH-15893 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2019

GH-15894 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@wwuck @miss-islington
bpo-38034: Fix typo in logging.handlers.rst (pythonGH-15708)
b1c22ab 
(cherry picked from commit efd5741)

Co-authored-by: wwuck <301402+wwuck@users.noreply.github.com>
willingc pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @wwuck @willingc
bpo-38034: Fix typo in logging.handlers.rst (GH-15708) (GH-15893)
f357cd0 
(cherry picked from commit efd5741)

Co-authored-by: wwuck <301402+wwuck@users.noreply.github.com>
willingc pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @wwuck @willingc
bpo-38034: Fix typo in logging.handlers.rst (GH-15708) (GH-15894)
2a8560a 
(cherry picked from commit efd5741)

Co-authored-by: wwuck <301402+wwuck@users.noreply.github.com>
@wwuck wwuck deleted the tomascassidy-patch-1 branch September 12, 2019 00:34
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@wwuck @websurfer5
bpo-38034: Fix typo in logging.handlers.rst (pythonGH-15708)
4199bba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wwuck @the-knights-who-say-ni @corona10 @vsajip @willingc @miss-islington @bedevere-bot @tirkarthi
X Tutup