gh-143663: Perform path normalization in TarFile.extractall()#143665
Open
0xd6cb6d73 wants to merge 10 commits intopython:mainfrom
Open
gh-143663: Perform path normalization in TarFile.extractall()#1436650xd6cb6d73 wants to merge 10 commits intopython:mainfrom
0xd6cb6d73 wants to merge 10 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
0xd6cb6d73
force-pushed
the
fix-issue-143663
branch
from
dd34127 to
c48bda8
Compare
Member
|
Please do not open a PR until the bug has been acknowledged. We can't just normalize all paths. Normalization is not the default behavior. I will close thbe PR until it has been decided that this change should be done. Sorry. |
Author
|
Ended up fixing the issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue on Windows caused by non-normalized destination paths when calling
extractall().