gh-59705: Make PYTHREAD_NAME_MAXLEN macro private#128945
Merged
vstinner merged 2 commits intopython:mainfrom Jan 18, 2025
Merged
gh-59705: Make PYTHREAD_NAME_MAXLEN macro private#128945vstinner merged 2 commits intopython:mainfrom
vstinner merged 2 commits intopython:mainfrom
Conversation
Rename PYTHREAD_NAME_MAXLEN to _PYTHREAD_NAME_MAXLEN.
vstinner
requested review from
a team,
corona10 and
erlend-aasland
as code owners
Member
Author
|
@zooba: Is it what you expected? To make the macro private? |
serhiy-storchaka
approved these changes
Jan 17, 2025
chris-eibl
reviewed
Jan 18, 2025
Member
|
I was thinking it didn't belong in pyconfig.h, but I didn't realise there was an autoconf switch picking values based on the platform. So yeah, this is fine by me, but if it already existed in public then we probably have to leave it there :( |
Member
Author
|
I would prefer to only declare this macro in the internal C API. But I have no idea how to do that :-( |
Member
|
I would prefer most of pyconfig.h be internal API, but that's long history now. We just have to live with it. Having the |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 21, 2025
Rename PYTHREAD_NAME_MAXLEN to _PYTHREAD_NAME_MAXLEN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename PYTHREAD_NAME_MAXLEN to _PYTHREAD_NAME_MAXLEN.