Closed
Conversation
added 2 commits
April 24, 2017 16:29
…#527) Many metaclasses in the standard library don't play nice with __init_subclass__. This bug makes ABCMeta in particular with __init_subclass__, which is an 80/20 solution for me personally. AFAICT, a general solution to this problem requires updating all metaclasses in the standard library to make sure they pass **kwargs to type.__new__, whereas this PR only fixes ABCMeta. For context, see https://bugs.python.org/issue29581. * added a test combining ABCMeta and __init_subclass__ * Added NEWS item (cherry picked from commit bd583ef)
…ythonGH-527) Many metaclasses in the standard library don't play nice with __init_subclass__. This bug makes ABCMeta in particular with __init_subclass__, which is an 80/20 solution for me personally. AFAICT, a general solution to this problem requires updating all metaclasses in the standard library to make sure they pass **kwargs to type.__new__, whereas this PR only fixes ABCMeta. For context, see https://bugs.python.org/issue29581. * added a test combining ABCMeta and __init_subclass__ * Added NEWS item. (cherry picked from commit bd583ef)
Contributor
Author
Member
|
There is an issue on the Misc/NEWS merge :-/ |
Contributor
Author
|
Oops. I don't see an easy way to fix this using the cherry_picker tool, so I'm going to abandon this PR and make a new one (merging correctly) this time, unless you object. Also, I note that there's a "No issue number in the title or "trivial" label" problem listed in 'checks'. Do you want me to add the issue label of the original issue (for which this is a backport), or stick with the auto-generated backport PR name? |
Contributor
|
@Soares The preferred format for backport PR titles is "[X.Y] bpo-NNNNN: ...", where X.Y is the target branch and NNNNN is the bugs.python.org issue number |
serhiy-storchaka
added
type-bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I followed the backporting instructions at https://docs.python.org/devguide/committing.html?highlight=backport correctly, but this is my first time, so please let me know if I erred, as is fairly likely.