gh-124285: Fix bug where bool() is called multiple times for the same part of a boolean expression#124394
Merged
iritkatriel merged 9 commits intopython:mainfrom Sep 25, 2024
Merged
Conversation
…e same part of a boolean expression
iritkatriel
commented
Sep 23, 2024
markshannon
approved these changes
Sep 24, 2024
Member
markshannon
left a comment
There was a problem hiding this comment.
Very nice.
One suggestion for a comment, otherwise lgtm.
Member
|
@ncoghlan on the issue suggested we could do this in the AST optimizer without changing the eval loop. Is that approach worth considering? It would involve transforming |
Member
Author
I'm not sure I see what the general solution is, but I'm all for trying it. |
Member
Author
|
I'll merge this though - we can easily replace this with the alternative idea. The "sequence" pseudo-ops change is worth having anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124285.
foo and 1 or 2: 3.12 newly convertsfooto bool twice #124285📚 Documentation preview 📚: https://cpython-previews--124394.org.readthedocs.build/