gh-124130: Notes on empty string corner case of category \B#124133
Merged
vstinner merged 1 commit intopython:mainfrom Sep 23, 2024
Merged
gh-124130: Notes on empty string corner case of category \B#124133vstinner merged 1 commit intopython:mainfrom
\B#124133vstinner merged 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
y5c4l3
changed the title
\B\B
y5c4l3
force-pushed
the
re-non-boundary
branch
2 times, most recently
from
01515bd to
5dfaf17
Compare
rruuaanng
reviewed
Sep 18, 2024
Misc/NEWS.d/next/Library/2024-09-16-23-35-08.gh-issue-124130.bKRyYk.rst
Outdated
Show resolved
Hide resolved
ZeroIntensity
requested changes
Sep 20, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
This is probably a breaking change, as mentioned in the original issue :(
Could you just add a documentation note with this PR?
y5c4l3
force-pushed
the
re-non-boundary
branch
from
5dfaf17 to
0313791
Compare
y5c4l3
changed the title
\B\B
Contributor
Author
Notes added. Could you label this PR with a |
ZeroIntensity
approved these changes
Sep 21, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM, thank you! This is pretty much all we can do about this problem.
ZeroIntensity
added
needs backport to 3.12
picnixz
reviewed
Sep 22, 2024
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Just check that Perl is indeed different or use another example (or drop it if you want).
Signed-off-by: y5c4l3 <y5c4l3@proton.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
y5c4l3
force-pushed
the
re-non-boundary
branch
from
0313791 to
947bc09
Compare
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 23, 2024
…ythonGH-124133) (cherry picked from commit d3e79d7) Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com> Signed-off-by: y5c4l3 <y5c4l3@proton.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-124328 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 23, 2024
…ythonGH-124133) (cherry picked from commit d3e79d7) Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com> Signed-off-by: y5c4l3 <y5c4l3@proton.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-124329 is a backport of this pull request to the 3.12 branch. |
Member
|
Merged, thanks. |
vstinner
pushed a commit
that referenced
this pull request
Sep 23, 2024
…H-124133) (#124329) gh-124130: Notes on empty string corner case of category `\B` (GH-124133) (cherry picked from commit d3e79d7) Signed-off-by: y5c4l3 <y5c4l3@proton.me> Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 23, 2024
…H-124133) (#124328) gh-124130: Notes on empty string corner case of category `\B` (GH-124133) (cherry picked from commit d3e79d7) Signed-off-by: y5c4l3 <y5c4l3@proton.me> Co-authored-by: Y5 <124019959+y5c4l3@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.