gh-112301: -fstack-protector-strong is also needed in LDFLAGS on Solaris/Illumos#121979
Closed
kulikjak wants to merge 3 commits intopython:mainfrom
Closed
gh-112301: -fstack-protector-strong is also needed in LDFLAGS on Solaris/Illumos#121979kulikjak wants to merge 3 commits intopython:mainfrom
-fstack-protector-strong is also needed in LDFLAGS on Solaris/Illumos#121979kulikjak wants to merge 3 commits intopython:mainfrom
Conversation
Member
|
see: #121996 (comment) |
kulikjak
force-pushed
the
Solaris-fstack-protector-fix
branch
from
16c3d48 to
5673fe7
Compare
kulikjak
force-pushed
the
Solaris-fstack-protector-fix
branch
from
5673fe7 to
cd9638a
Compare
Member
|
I close this PR since it's inactive since July 2024: #112301 (comment). If you are still hitting the issue, I suggest opening a new PR. By the way, I'm not sure that modifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linker on Solaris/Illumos is unhappy when you pass
-fstack-protector-strongflag viaCFLAGSbut notLDFLAGS, resulting in the following failure after #120975:I don't think that other links will mind, but I can certainly make this into a Solaris/Illumos specific
LDFLAGSappend.