gh-119698: fix a special case in symtable.Class.get_methods#121802
gh-119698: fix a special case in symtable.Class.get_methods#121802JelleZijlstra merged 10 commits intopython:mainfrom
symtable.Class.get_methods#121802Conversation
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Yeah, deprecating this may be the right call after all.
|
So, I deprecated the method but kept the fix (I can also revert all the fixes and just mark it as deprecated, but I think it's better to keep something that is working even though we are deprecating it) |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I suggest to split this PR on two. The genexpr fix should be backported to 3.13 and 3.12. The deprecation should only be applied to 3.14.
|
I forgot that we backported the original fix... Thanks Serhiy, it should definitely be split into two! |
|
(FTR, the last commit is just about reverting some RST content that will be included in the next PR (Serhiy approved the changes at the same time I pushed the commit)) |
picnixz
added
needs backport to 3.12
|
Thanks @picnixz for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…ythonGH-121802) (cherry picked from commit 6682d91) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…ythonGH-121802) (cherry picked from commit 6682d91) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-121909 is a backport of this pull request to the 3.13 branch. |
|
GH-121910 is a backport of this pull request to the 3.12 branch. |
3 participants
cc @JelleZijlstra @serhiy-storchaka
So, this is the fix of the fix for the following bug: #119698 (comment)
While this fixes what I did, I'm less and less convinced about keeping the method as well...
Well.. it indeed becomes more and more complex =/ the tests are not really complex but we need a lot of them just to be sure that we cover the cases. Maintenance cost is not that much for me, unless the symtable changes. However, I agree that usefulness is questionable... (still didn't manage to find concrete use cases =/)