[2.7] closes bpo-13497: Fix broken nice configure test. (GH-12041)#12043
Merged
miss-islington merged 1 commit intopython:2.7from Feb 26, 2019
Merged
[2.7] closes bpo-13497: Fix broken nice configure test. (GH-12041)#12043miss-islington merged 1 commit intopython:2.7from
broken nice configure test. (GH-12041)#12043miss-islington merged 1 commit intopython:2.7from
Conversation
Per POSIX, `nice(3)` requires `unistd.h` and `exit(3)` requires `stdlib.h`. Fixing the test will prevent false positives with pedantic compilers like clang. (cherry picked from commit 90c6fac) Co-authored-by: ngie-eign <1574099+ngie-eign@users.noreply.github.com>
benjaminp
approved these changes
Feb 26, 2019
Contributor
Author
|
@ngie-eign and @benjaminp: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per POSIX,
nice(3)requiresunistd.handexit(3)requiresstdlib.h.Fixing the test will prevent false positives with pedantic compilers like clang.
(cherry picked from commit 90c6fac)
Co-authored-by: ngie-eign 1574099+ngie-eign@users.noreply.github.com
https://bugs.python.org/issue13497